fix: allowing unknown solvers through mirror solved-issue pipeline#87
Open
jonathanchang31 wants to merge 1 commit into
Open
fix: allowing unknown solvers through mirror solved-issue pipeline#87jonathanchang31 wants to merge 1 commit into
jonathanchang31 wants to merge 1 commit into
Conversation
anderdc
requested changes
May 20, 2026
Collaborator
anderdc
left a comment
anderdc
left a comment
There was a problem hiding this comment.
Scope this down to the one-line read-time guard.
Keep:
miners.service.ts:158addingAND BTRIM(sp.author_github_id) <> ''— that single line filters out both legacy''rows and any future blank writes, fully resolving the API-surface leak.
Drop:
- The TS change in
github-fetcher.service.ts— once the read-time guard exists, the column value isn't user-visible whether it's''orNULL, so writingNULLprospectively is cleanup without payoff. packages/db/26_normalize_blank_pr_author_ids.sql— the guard makes legacy blanks invisible at read time; no schema-tree file or migration runbook needed.
Also drop the Fixes: reference (already removed from the description) — #85 was closed because the prescribed multi-step fix was over-scoped for the user-facing impact (phantom solver rows don't misroute scoring since registered miners can't have empty github_ids). The one-liner captures the win without the schema-tree change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes a scoring-integrity bug where backfill stored missing PR author IDs as empty strings (
'') instead ofNULL. Because solver selection only filteredIS NOT NULL, unknown solver identities leaked intosolving_pr.Change Type (select all)
Root Cause
authorGithubId: String(pr.author?.databaseId ?? "")sp.author_github_id IS NOT NULLResult: unknown solver IDs (
'') were treated as present and returned in solved-issue pipeline.Real Behavior Proof
Before
author_github_id = ''IS NOT NULLtrue)After
author_github_id = NULLsolving_pras intendedChecklist